feat(dotnet): add initial .NET SDK and installer#27
Conversation
sdks/dotnet/.gitignore
Outdated
| @@ -0,0 +1,15 @@ | |||
| # Build outputs | |||
| **/bin/ | |||
There was a problem hiding this comment.
it looks like some of the dirs are already ignored in the root .gitignore,
There was a problem hiding this comment.
I removed this redundant file
sdks/dotnet/TestServerSdk.cs
Outdated
| { | ||
| var targetDir = Path.GetDirectoryName(p) ?? Path.GetFullPath(Directory.GetCurrentDirectory()); | ||
| Console.WriteLine($"[TestServerSdk] test-server not found at {p}. Installing into {targetDir}..."); | ||
| BinaryInstaller.EnsureBinaryAsync(targetDir, "v0.2.5").GetAwaiter().GetResult(); |
There was a problem hiding this comment.
Do we need to update this value when releasing a new go server version?
There was a problem hiding this comment.
so far yes. I tried to automatically grep the latest, but that introduced a lot of brittles. And then I looked into typescript implementation, it is also hard coded so far
| { | ||
| static async Task<int> Main(string[] args) | ||
| { | ||
| var version = args.Length > 0 ? args[0] : "v0.2.5"; |
There was a problem hiding this comment.
same here, do we need to update the version after each release?
There was a problem hiding this comment.
so far yes. I tried to automatically grep the latest, but that introduced a lot of brittles. And then I looked into typescript implementation, it is also hard coded so far
2 participants
No description provided.